On Thu, Apr 23, 2015 at 11:13:47PM +0200, Marek Vasut wrote: > On Thursday, April 23, 2015 at 03:13:51 PM, Tom Rini wrote: > > On Thu, Apr 23, 2015 at 06:08:43PM +0530, maitysancha...@gmail.com wrote: > > > Hello, > > > > > > On 15-04-15 16:24:21, Sanchayan Maity wrote: > > > > Hello, > > > > > > > > This is the third version of the patchset which adds support for the > > > > Toradex Colibri Vybrid VF50 and VF61 modules. Boot up has been tested > > > > using the serial loader over UART. Compile tested for > > > > vf610twr_defconfig and vf610twr_nand_defconfig as well. > > > > > > > > First patch in the series refactors the DDR related code for use by > > > > both the tower board and colibri modules. It also introduces a DDR3 > > > > based JEDEC timing structure. > > > > > > > > Second third and fourth patch in this series are improvement patches > > > > related to RTC, SoC/CPU detection and caches. > > > > > > > > Fifth patch introduces USB support for Vybrid modules. Much of the code > > > > is similar to the ehci-mx6 driver. Both host and client modes are > > > > working and DFU has also been tested with client. Currently, we > > > > restrict the ports to be in one of host and client mode. > > > > > > > > Sixth patch adds the actual support for the Colibri modules. > > > > > > > > Comments and feedback are most welcome. Thanks for the feedback till > > > > now. > > > > > > > > The patchset is based and tested on the latest master branch as of > > > > this writing. > > > > > > > > Discussion on the version 2 of the patchset can be found at the below > > > > link: > > > > https://www.mail-archive.com/u-boot@lists.denx.de/msg168727.html > > > > > > > > Discussion on the version 1 of the patchset can be found at the below > > > > link: > > > > https://www.mail-archive.com/u-boot@lists.denx.de/msg168136.html > > > > > > > > Changes since v2: > > > > - Rework the USB driver to use register + offset method in light of > > > > discussion which Fabio Estevam pointed out instead of the regular > > > > struct{} method which v2 used. The discussion is at the below link: > > > > https://www.marc.info/?l=u-boot&m=142609602127309&w=2 > > > > > > > > - Reorder the patchset, putting the USB support in the end and add an > > > > additional patch for adding USB support to Colibri modules. By chance > > > > if more discussions happen on the USB support, this allows picking up > > > > of atleast the first patches on which no issues have been reported so > > > > far. > > > > > > > > - The register definitions have been moved under arch/arm/include/asm/ > > > > imx-common in the regs-usbphy.h file. This was agreed on after > > > > discussion with Marek and some input from Peter Chen. Since it is not > > > > clear if SoC's other than Freescale's use the Sigmatel Phy's which seem > > > > to be use in iMX/VF/MXS, put the USH PHY register definitions in > > > > imx-common rather than include/usb in a chipidea specific file. > > > > > > > > - Remove setting of a PLL divisor select which was added for USB but is > > > > actually not required considering default value. It also seems to break > > > > USB after my latest rebase. The file in question concerning the change > > > > is colibri_vf.c. PLL divisor selects the PLL Multiplication factor > > > > which by default is 0, setting Fout = Fref * 20 giving 480MHz. The > > > > earlier patch set this to 1 giving Fout = Fref * 22 where Fref = > > > > 24MHz. > > > > > > > > - Rebased on the latest master branch. > > > > > > > > Changes since v1: > > > > - Rework the USB driver to use register offsets using the regular > > > > struct {} method > > > > > > > > - Some cleanups and fixes in the sixth patch for the colibri_vf.h file > > > > which takes care of environment variables in uboot > > > > > > > > - Purge some useless defines in the fifth and sixth patch which were > > > > related to USB. > > > > > > Ping!? > > > > > > Anything preventing this patch from getting applied? > > > > I'll pick this up soon, thanks! > > This should go through u-boot-imx though ;-)
For the record, since they aren't quite imx platforms I didn't want to throw another SoC on someone elses plate. Stefano, do you want to handle all the Vybrid stuf in the future? Thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot