Hi Simon, On Wed, Apr 29, 2015 at 10:08 AM, Simon Glass <s...@chromium.org> wrote: > Hi Bin, > > On 28 April 2015 at 02:16, Bin Meng <bmeng...@gmail.com> wrote: >> Hi Simon, >> >> On Tue, Apr 28, 2015 at 6:48 AM, Simon Glass <s...@chromium.org> wrote: >>> Add a function to return the address of the Interrupt Descriptor Table. >>> >>> Signed-off-by: Simon Glass <s...@chromium.org> >>> --- >>> >>> arch/x86/cpu/interrupts.c | 5 +++++ >>> arch/x86/include/asm/interrupt.h | 2 ++ >>> 2 files changed, 7 insertions(+) >>> >>> diff --git a/arch/x86/cpu/interrupts.c b/arch/x86/cpu/interrupts.c >>> index a21d2a6..c777d36 100644 >>> --- a/arch/x86/cpu/interrupts.c >>> +++ b/arch/x86/cpu/interrupts.c >>> @@ -147,6 +147,11 @@ int cpu_init_interrupts(void) >>> return 0; >>> } >>> >>> +void *x86_get_idt(void) >>> +{ >>> + return &idt_ptr; >>> +} >>> + >> >> idt_ptr is not declared as static, so this is unneeded? Or should we >> change it to static? > > I think it is better to access it via a function. It is used from > assembler so I would rather not make it static. Any thoughts? >
OK, fair enough. [snip] Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot