Hi Masahiro,
On 08.05.2015 05:30, Masahiro Yamada wrote:
2015-05-08 8:51 GMT+09:00 Simon Glass <s...@chromium.org>:
Hi Stefan,
On 7 May 2015 at 06:13, Stefan Roese <s...@denx.de> wrote:
This patch moves the following config options to Kconfig:
CONFIG_AUTOBOOT_KEYED
CONFIG_AUTOBOOT_PROMPT
CONFIG_AUTOBOOT_DELAY_STR
CONFIG_AUTOBOOT_STOP_STR
AUTOBOOT_KEYED_CTRLC
Signed-off-by: Stefan Roese <s...@denx.de>
Cc: Masahiro Yamada <yamada.masah...@socionext.com>
Cc: Simon Glass <s...@chromium.org>
Thanks for working on a task requiring much effort.
Yes. I really admire you for all your hard work on this. Now that I've
done a tiny bit here as well. ;)
I am just wondering if we need not move the prompt messages verbatim to Kconfig.
I know CONFIG_AUTOBOOT_PROMPT provides us the best flexibility,
but the messages are most likely "autoboot in %d seconds" or "Press ...".
Can we put the message directly into common/autoboot.c like this?
#ifdef CONFIG_SHOW_AUTOBOOT_PROMPT
printf("Autoboot in %d seconds\n", CONFIG_BOOTDELAY);
printf("Press %c to abort in %d seconds\n", CONFIG_AUTOBOOT_STOP_STR);
#endif
I think I am missing some things here:
- Those boards that require a password do not want to show it
- We need to convert " " to user-visible "<SPACE>" if
CONFIG_AUTOBOOT_STOP_STP == " "
Any ideas?
Unfortunately not all boards print such a message. There is quite a
range of alternatives, I'm afraid. Some boards use
CONFIG_AUTOBOOT_STOP_STR, some CONFIG_AUTOBOOT_DELAY_STR. Some print
this string / char, some don't. So we can't really convert them all into
such a generic implementation. Without breaking backward (user)
compatibility. At least I don't see such a way.
Thanks,
Stefan
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
