On Thu, 2015-05-21 at 20:39 +0200, Hans de Goede wrote: [...] > Please create a struct reflecting the register layout and > then initialize a ptr to this struct from the base-address > and get register addresses this way, this is how we deal > with this in pretty much all other sunxi code, see e.g.:
This isn't just sunxi, I believe it is u-boot's preferred way to do things generally. [...] > Otherwise this looks like a good start, with the coding > style issues fixed I would not be opposed against merging > this as a first step to growing proper nand support. > > Ian, is that ok with you ? You mean with the coding style fixed but not (necessarily) all the other issues you pointed out (timeouts on loops, structs for register accesses)? I think at least the structs for register access stuff should be fixed first, especially given it was already raised in the previous round of review. Ian _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot