Hi Tom, On Fri, Jun 12, 2015 at 7:08 AM, Tom Rini <tr...@konsulko.com> wrote: > On Thu, Jun 11, 2015 at 11:12:43AM -0500, Joe Hershberger wrote: >> Hi Tom, >> >> On Thu, Jun 11, 2015 at 10:12 AM, Tom Rini <tr...@konsulko.com> wrote: >> > On Thu, Jun 11, 2015 at 09:14:33AM -0500, Joe Hershberger wrote: >> >> Hi Tom, >> >> >> >> On Wed, Jun 3, 2015 at 5:12 PM, Tom Rini <tr...@konsulko.com> wrote: >> >> > On Wed, Jun 03, 2015 at 08:12:16PM +0200, Hans de Goede wrote: >> >> > >> >> >> Select CONFIG_CMD_NET and CONFIG_CMD_SETEXPR by default rather then >> >> >> needing to have this in every sunxi defconfig file. >> >> >> >> >> >> This also fixes the Merrii_A80_Optimus defconfig no longer building. >> >> >> >> >> >> Cc: Maxin B. John <maxin.j...@enea.com> >> >> >> Reported-by: Maxin B. John <maxin.j...@enea.com> >> >> >> Signed-off-by: Hans de Goede <hdego...@redhat.com> >> >> > >> >> > Joe? Masahiro? It feels like something has gone wrong with the >> >> > conversion here. Or do people need to get used to the defconfig files >> >> > being a non-trivial size? Or do we need some more default y if ... >> >> > lines around things? Or a few of the above? Thanks! >> >> >> >> I'm surprised you pulled this in for -rc2. I guess we can always revert >> >> it. >> > >> > OK, so where did we end up again exactly? Ah yes, (a) we can't >> > unexpectedly break peoples build. So I took this for now. >> >> This isn't fixing a breakage... it simply reduced the size of the >> sunxi boards' defconfig and caused defconfig noise in every other >> board when running savedefconfig. >> >> > (b) I'm being stubborn here and saying that if it was in >> > include/config_cmd_default.h as a #define it needs to get converted to >> > Kconfig as a "default y" (with text so that it's a question and not a >> > silently enforced option). >> >> Agreed... but this doesn't do that either... only for sunxi. >> >> > That doesn't preclude boards from setting it >> > to N in their defconfig and savedefconfig capturing it. That's in fact >> > what I want. So I'm expecting (or hunting for time to make) a patch >> > that updates CMD_NET/etc to match that behavour. >> >> OK... I can take a stab at it if you want it for this release. > > Yes please, thanks!
I just sent a series that addresses this request. It is pretty big so it will be blocked by the mailing list until a moderator sees it. There were a number of boards that fail for me in master, but I'm not sure if that's just my toolchains or if there are build failures on a number of boards currently in master. For me it was: sparc: + grsim_leon2 gr_cpci_ax2000 gr_xc3s_1500 gr_ep2s60 sh: + sh7753evb blackfin: + cm-bf548 bf538f-ezkit bf533-stamp powerpc: + ebony taihu ocotea taishan katmai CPCI4052 alpr aarch64: + ls2085ardb ls2085aqds_nand ls2085a_emu_D4 ls2085a_simu xilinx_zynqmp ls2085ardb_nand ls2085a_emu ls2085aqds arm: + openrd_base axm openrd_ultimate openrd_client zynq_zc70x tricorder tricorder_flash taurus I think the blackfin board failures Masahiro mentioned were caused by one of my patches to the network stack or something, so I'll look into that. Cheers, -Joe _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot