Hello Marek,
Am 21.07.2015 um 04:03 schrieb Marek Vasut:
On Monday, July 20, 2015 at 04:03:08 PM, Lukasz Majewski wrote:
Hi Marek,
add dfu supprt for at91 sam9260 based boards. The USB
gadget driver is ported from linux:
b2ba27a5c56ff: usb: gadget: at91_udc: move prepare clk into process
context
it drops a lot of checkpatch warnings/errors:
checkpatch.pl found 12 error(s), 31 warning(s), 43 checks(s)
but for further updates I did not fix them.
The errors are all from this sort:
error: drivers/usb/gadget/at91_udc.c,87: space prohibited before open
square bracket '['
a lot of "line over 80 characters" warnings ...
Heiko Schocher (3):
ARM: at91: add cpu.h
usb: gadget: at91_udc: add support for at91_udc
at91, taurus, smartweb: add dfu support
Marek, do you plan to review this patch series?
(I would need at least one review before I pull the code).
I took a brief look. One thing I don't quite like is the omnipresent #ifdef
__UBOOT__ stuff. I'd much rather love to see some kind of a porting layer
so the driver can just be picked from linux as-is, but that might be too much
hassle.
Yes, such a layer would be beautiful, but it is possible? We have
no processes/task switching in U-Boot ... a lot of board do not use
irqs ...
Otherwise, I'm fine with it, though I nitpicked a bit.
I just prepare a v2 ...
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
