On Wednesday, August 12, 2015 at 01:38:23 AM, Masahiro Yamada wrote: > Hi Marek,
Hi Masahiro! > 2015-08-12 7:47 GMT+09:00 Marek Vasut <ma...@denx.de>: > > On Wednesday, August 12, 2015 at 12:31:54 AM, Masahiro Yamada wrote: > > > > Hi! > > > >> As we discussed a couple of times, negative CONFIG options make our > >> life difficult; CONFIG_SYS_NO_FLASH, CONFIG_SYS_DCACHE_OFF, ... > >> and here is another one. > >> > >> Now, there are three boards enabling OF_CONTROL on SPL: > >> - socfpga_arria5_defconfig > >> - socfpga_cyclone5_defconfig > >> - socfpga_socrates_defconfig > >> > >> This commit adds CONFIG_SPL_OF_CONTROL for them and deletes > >> CONFIG_SPL_DISABLE_OF_CONTROL from the other boards to invert > >> the logic. > >> > >> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> > >> Reviewed-by: Tom Rini <tr...@konsulko.com> > >> Reviewed-by: Simon Glass <s...@chromium.org> > > > > Wouldn't it make more sense for the SOCFPGA stuff to simply select > > CONFIG_OF_CONTROL and CONFIG_SPL_OF_CONTROL in > > arch/arm/mach-socfpga/Kconfig by default instead of adding it into each > > boards' config file ? > > It will make sense if SOCFPGA only works with > CONFIG_OF_CONTROL and CONFIG_SPL_OF_CONTROL enabled. It does, non-DT and non-DM operation is prohibited and forbidden on SoCFPGA. Thanks for confirming it's possible to enable those in Kconfig by default instead. I can send a patch to convert the socfpga this way later :) > It was not clear if they were forcible or not > because CONFIG_OF_CONTROL was defined in the defconfig, so I am following > it. Yeah, all SoCFPGA boards use DT and DM support in both U-Boot and SPL. It's really the state-of-the-art implementation :b Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot