On 08/22/2015 11:04 AM, Hans de Goede wrote: > From: Roy Spliet <r.spl...@ultimaker.com> > > Under the assumptions of having a UBI volume called boot, containing > a ubifs filesystem. > > Signed-off-by: Hans de Goede <hdego...@redhat.com>
I'd expect the person in the "From:" line above to have an s-o-b line too. If the patch has changed so much that isn't appropriate, perhaps change the patch's git author to you and just mentioned "Based on work by: Roy ..."? > diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h > +#ifdef CONFIG_CMD_UBIFS > +#define BOOTENV_SHARED_UBIFS \ > + "ubifs_boot=" \ > + "if ubi part UBI && ubifsmount ubi${devnum}:boot; then " \ I don't know ubifs well enough to know the implications of that particular set of ubi commands, but as far as the impact-on/integration-into the bootcmd.h file, this patch looks fine. Acked-by: Stephen Warren <swar...@nvidia.com> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot