On Wednesday 22 July 2009 13:05:56 Wolfgang Denk wrote: > I don't understand what's so difficult about it; just indent by TABs: > > struct ppc4xx_config ppc4xx_config_val[] = { > { > "133", > "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66", > { > 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > 0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00, > } > },
OK, now let's compare your version with ours: > + { "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66", > + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } }, Your version is 10 lines long, ours is 5. That twice as long. I still prefer our version and think this kind of personal freedom should be allowed. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot