On Tue, Sep 15, 2015 at 2:32 PM, Bin Meng <bmeng...@gmail.com> wrote: > Hi Jagan, > > On Wed, Sep 2, 2015 at 2:09 PM, Jagan Teki <jt...@openedev.com> wrote: >> Use the flash->flags for generic usage, not only for dm-spi-flash, >> this will be used for future flag additions. >> >> Signed-off-by: Jagan Teki <jt...@openedev.com> >> Cc: Bin Meng <bmeng...@gmail.com> >> --- > > This v3 commit still breaks Intel Crown Bay. I've tested on latest > u-boot/master branch plus this single commit. A simple 'saveenv' just > erase all contents without reporting any error. > > => md ffe00000 > ffe00000: a38ec887 64756162 65746172 3531313d ....baudrate=115 > ffe00010: 00303032 746f6f62 73677261 6f6f723d 200.bootargs=roo > ffe00020: 642f3d74 732f7665 20336264 74696e69 t=/dev/sdb3 init > ffe00030: 62732f3d 692f6e69 2074696e 746f6f72 =/sbin/init root > ffe00040: 74696177 006f7220 746f6f62 3d646d63 wait ro.bootcmd= > ffe00050: 32747865 64616f6c 73637320 3a302069 ext2load scsi 0: > ffe00060: 31302033 30303030 2f203030 746f6f62 3 01000000 /boot > ffe00070: 6c6d762f 7a756e69 627a203b 20746f6f /vmlinuz; zboot > ffe00080: 30303130 30303030 6f6f6200 6c696674 01000000.bootfil > ffe00090: 7a623d65 67616d49 6f630065 6c6f736e e=bzImage.consol > ffe000a0: 76656465 7974743d 65003053 61316874 edev=ttyS0.eth1a > ffe000b0: 3d726464 313a3030 37313a35 3a63653a ddr=00:15:17:ec: > ffe000c0: 653a3165 74650038 64613268 303d7264 e1:e8.eth2addr=0 > ffe000d0: 35313a30 3a37313a 653a6365 39653a31 0:15:17:ec:e1:e9 > ffe000e0: 68746500 72646461 3a30303d 323a3331 .ethaddr=00:13:2 > ffe000f0: 39663a30 3a65303a 67006439 77657461 0:f9:0e:9d.gatew > > => saveenv > Saving Environment to SPI Flash... > Erasing SPI flash...Writing to SPI flash...done > > => md ffe00000 > ffe00000: ffffff01 ffffffff ffffffff ffffffff ................ > > Note there is a suspicious 01 at the first byte location. I think the > flash erase succeeded, but flash write does not and failed at the very > first byte. But I don't know why it does not report any error to > 'saveenv' (the upper layer). > > ffe00010: ffffffff ffffffff ffffffff ffffffff ................ > ffe00020: ffffffff ffffffff ffffffff ffffffff ................ > ffe00030: ffffffff ffffffff ffffffff ffffffff ................ > ffe00040: ffffffff ffffffff ffffffff ffffffff ................ > ffe00050: ffffffff ffffffff ffffffff ffffffff ................ > ffe00060: ffffffff ffffffff ffffffff ffffffff ................ > ffe00070: ffffffff ffffffff ffffffff ffffffff ................ > ffe00080: ffffffff ffffffff ffffffff ffffffff ................ > ffe00090: ffffffff ffffffff ffffffff ffffffff ................ > ffe000a0: ffffffff ffffffff ffffffff ffffffff ................ > ffe000b0: ffffffff ffffffff ffffffff ffffffff ................ > ffe000c0: ffffffff ffffffff ffffffff ffffffff ................ > ffe000d0: ffffffff ffffffff ffffffff ffffffff ................ > ffe000e0: ffffffff ffffffff ffffffff ffffffff .............. >
I've figured it out. Please check the patch @ http://patchwork.ozlabs.org/patch/517704/. Thanks! [snip] Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot