Hi,
On 28-09-15 17:10, Tom Rini wrote:
On Wed, Sep 23, 2015 at 10:25:35AM -0700, Ryan Harkin wrote:
As config migrates from board config files to Kconfig, when adding
CONFIG_SYS_BOOTM_LEN to a platform, I decided to add
Kconfig support for CONFIG_SYS_BOOTM_LEN.
Signed-off-by: Ryan Harkin <ryan.har...@linaro.org>
Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
CC: Masahiro Yamada <yamad...@jp.panasonic.com>
CC: Simon Glass <s...@chromium.org>
CC: Linus Walleij <linus.wall...@linaro.org>
Thanks for trying to do this. The problem however is that you need to
use tools/moveconfig.py so that all of the other boards (which is a lot)
get updated too, otherwise they fail to build.
No, just no, not more polluting of defconfig files with things which really
belong in a per SoC file not a per board file.
I think we can fix the "make savedefconfig" warnings by doing something like
this in a per SoC Kconfig file:
if ARCH_SUNXI
defconfig SYS_BOOTM_LEN
default 0x0f000000 if ARCH_SUNXI
endif
The second "if ARCH_SUNXI" is necessary to stop the script calling
"make savedefconfig" for all boards to clean the defconfig files from
complaining.
Please let set per SoC defaults this way rather then turning the defconfig
files in a mixture of board / soc settings where as they should really
only select the SoC and then contain board specific settings on top of
that.
Regards,
Hans
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
