On 29 September 2015 at 05:33, Simon Glass <s...@chromium.org> wrote: > On 28 September 2015 at 04:41, Przemyslaw Marczak <p.marc...@samsung.com> > wrote: >> Hello Stephen, >> >> >> On 09/25/2015 06:11 PM, Stephen Warren wrote: >>> >>> From: Stephen Warren <swar...@nvidia.com> >>> >>> fdtdec_get_addr_size() may be used in two cases: >>> a) With sizep supplied, in which case both an address and a size are >>> parsed from DT. In this case, the DT property must be large enough to >>> contain both values. >>> b) With sizep NULL, in which case only an address is parsed from DT. >>> In this case, the DT property only need be large enough to contain this >>> address value. Commit 02464e386bb5 "fdt: add new fdt address parsing >>> functions" broke this relaxed checking, and required the DT property to >>> contain both an address and a size value in all cases. >>> >>> Fix fdtdec_get_addr_size() to vary ns based on whether the size value >>> is being parsed from the DT or not. This is safe since the function only >>> parses the first entry in the property, so the overall value of (na + ns) >>> need not be accurate, since it is never used to step through the property >>> data to find other entries. Besides, this fixed behaviour essentially >>> matches the original behaviour before the patch this patch fixes. (The >>> original code validated that the property was exactly the length of >>> either na or (na + ns), whereas the current code only validates that the >>> property is at least that long. For non-failure cases, the two behaviours >>> are identical). >>> >>> Cc: Przemyslaw Marczak <p.marc...@samsung.com> >>> Cc: Simon Glass <s...@chromium.org> >>> Cc: Thierry Reding <tred...@nvidia.com> >>> Cc: Bin Meng <bmeng...@gmail.com> >>> Cc: Michal Suchanek <hramr...@gmail.com> >>> Fixes: 02464e386bb5 ("fdt: add new fdt address parsing functions") >>> Reported-by: Przemyslaw Marczak <p.marc...@samsung.com> >>> Signed-off-by: Stephen Warren <swar...@nvidia.com> >>> --- >>> lib/fdtdec.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) > > Acked-by: Simon Glass <s...@chromium.org>
Applied to u-boot-fdt, thanks! _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot