On Saturday 25 July 2009 23:25:00 Robin Getz wrote:
> On Sat 25 Jul 2009 22:49, Mike Frysinger pondered:
> > On Saturday 25 July 2009 16:07:49 Robin Getz wrote:
> > > +#ifdef CONFIG_CMD_MD5SUM
> > > +U_BOOT_CMD(
> > > + md5sum, 3,      1,      do_md5sum,
> > > + "compute MD5 message digest",
> > > + "address count"
> > > +);
> > > +#endif
> > > +
> > > +#ifdef CONFIG_CMD_SHA1
> > > +U_BOOT_CMD(
> > > + sha1,   3,      1,      do_sha1,
> > > + "compute SHA1 message digest",
> > > + "address count"
> > > +);
> > > +#endif /* CONFIG_CMD_SHA1 */
> >
> > there's no need for these to be at the bottom of the file.  move the
> > U_BOOT_CMD() into the releated #ifdef block.
>
> I'm just doing the same as all the other things in the same file (which
> doesn't mean it is correct). What is the preferred style?

ive been merging them to reduce #ifdef noise
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to