Hi,

Looks good to me.

Acked-by: Jaehoon Chung <jh80.ch...@samsung.com>

Best Regards,
Jaehoon Chung

On 10/28/2015 11:41 PM, Przemyslaw Marczak wrote:
> There are 8 pins for SD card in Exynos, but the MUX was configured
> only for 7, since the one was used for card detection.
> This caused the pin's pull wrong configuration.
> 
> This commit fixes this and the card detect can work properly,
> after call this function.
> 
> Tested-on: Odroid U3 and Odroid X2.
> 
> Signed-off-by: Przemyslaw Marczak <p.marc...@samsung.com>
> Cc: Guillaume GARDET <guillaume.gar...@free.fr>
> Cc: Lukasz Majewski <l.majew...@samsung.com>
> Cc: Jaehoon Chung <jh80.ch...@samsung.com>
> Cc: Minkyu Kang <mk7.k...@samsung.com>
> Cc: Simon Glass <s...@chromium.org>
> ---
>  arch/arm/mach-exynos/pinmux.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-exynos/pinmux.c b/arch/arm/mach-exynos/pinmux.c
> index 179b294..925bd0a 100644
> --- a/arch/arm/mach-exynos/pinmux.c
> +++ b/arch/arm/mach-exynos/pinmux.c
> @@ -737,10 +737,10 @@ static int exynos4x12_mmc_config(int peripheral, int 
> flags)
>               return -1;
>       }
>       for (i = start; i < (start + 7); i++) {
> +             gpio_set_pull(i, S5P_GPIO_PULL_NONE);
>               if (i == (start + 2))
>                       continue;
>               gpio_cfg_pin(i,  func);
> -             gpio_set_pull(i, S5P_GPIO_PULL_NONE);
>               gpio_set_drv(i, S5P_GPIO_DRV_4X);
>       }
>       if (flags & PINMUX_FLAG_8BIT_MODE) {
> 

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to