On Friday, October 30, 2015 at 05:26:25 PM, Stefan Agner wrote: > On 2015-10-30 09:24, Marek Vasut wrote: > > On Friday, October 30, 2015 at 05:12:54 PM, Stefan Agner wrote: > >> Hi All, > > > > Hi! > > > >> On 2015-10-30 05:26, Sanchayan Maity wrote: > >> > + > >> > +int board_usb_phy_mode(int port) > >> > +{ > >> > + switch (port) { > >> > + case 0: > >> > + return gpio_get_value(USB_CDET_GPIO); > >> > + break; > >> > + case 1: > >> > + return USB_INIT_HOST; > >> > + break; > >> > + default: > >> > + return USB_INIT_HOST; > >> > + break; > >> > >> One thing I would like to note in this whole discussion is that the old > >> setup is kind of the "default" role of each dual-role controller: The > >> boot ROM uses USB1 as client, the tower board uses this configuration > >> too... So maybe we could/should keep that default role at least in here? > > > > Well we cannot, since this is a custom board, right ? > > Ah sorry, the switch statement is enumerating the port numbers, hence > this default refers to ports > 2. Somehow read that the wrong way > around.
Well, if it is not obvious to you, comment in the code is a good idea. Sanchayan, please add one. Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot