Hello Minkyu,
On 11/04/2015 04:43 PM, Minkyu Kang wrote:
Dear Przemyslaw Marczak,
On 4 November 2015 at 18:37, Przemyslaw Marczak <p.marc...@samsung.com
<mailto:p.marc...@samsung.com>> wrote:
Hello Minkyu,
On 11/04/2015 03:05 AM, Minkyu Kang wrote:
Dear Przemyslaw Marczak,
2015년 11월 4일 수요일, Tom Rini<tr...@konsulko.com
<mailto:tr...@konsulko.com>
On Tue, Nov 03, 2015 at 02:02:57PM +0900, Minkyu Kang wrote:
> Dear Tom,
>
> The following changes since commit
0e067a65f57189703668826d9841fea477026bf6:
>
> x86: Select the ns16550 debug UART for minnowmax,
chromebook_link (2015-10-30 18:04:14 -0400)
>
> are available in the git repository at:
>
> http://git.denx.de/u-boot-samsung
>
> for you to fetch changes up to
de5f9733f653091d4b227914d04432099a6448dc:
>
> samsung: clean up checkpatch issues (2015-11-02
10:38:22 +0900)
>
NAK:
+(sandbox) ../drivers/adc/sandbox.c:11:25: fatal error:
sandbox-adc.h: No such file or directory
+(sandbox) #include <sandbox-adc.h>
+(sandbox) ^
+(sandbox) compilation terminated.
+(sandbox) make[3]: *** [drivers/adc/sandbox.o] Error 1
+(sandbox) make[2]: *** [drivers/adc] Error 2
+(sandbox) make[1]: *** [drivers] Error 2
"sandbox: add ADC unit tests" is missing adding sandbox-adc.h
Could you please check it?
--
Tom
Thanks,
Minkyu Kang.
--
Thanks.
Minkyu Kang.
Sorry for this mistake. I have this file locally, so it build
properly for me.
Is that good to you if I send you a patch with this missing file, to
squash with one commit? Or do you prefer V3 of the whole patch-set?
If squash your patch then I should do push forced.
I think it's not a good way.
I will merge your patch separately.
Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net <http://www.promsoft.net>
Squashing would be better if we want prevent build break. This single
file (include/sandbox-adc.h) will not conflict with any other, so it's
easy to rebase it.
This is not a master tree, so I think that push with force will not
cause any problems.
But if you really prefer to take it as a separate patch, then I will
send one, with a proper commit message in a moment.
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marc...@samsung.com
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
