On 11/04/2015 05:43 PM, Nishanth Menon wrote: [...] >> index 5cd6873f5e97..9d85d31b2cf1 100644 >> --- a/board/ti/am57xx/Makefile >> +++ b/board/ti/am57xx/Makefile >> @@ -6,3 +6,5 @@ >> # >> >> obj-y := board.o >> +obj-y += ../common/board.o >
One final comment on the ../common/board.o: all we need is: board/ti/common/Makefile which contains: obj-${CONFIG_I2C} += board-detect.o That should build it for all TI platforms and then optimize link time using __maybe_unused. This also removes the cruft of including specific headers since root Makefile already will enable flag HAVE_VENDOR_COMMON_LIB if a Makefile exists in board/{vendor}/common/ directory, and will build accordingly. This makes sense now since the entire series claims commonality and should allow us to remove stuff from am335x/437x following this series by just using the APIs. -- Regards, Nishanth Menon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot