Hi Lin, On 9 November 2015 at 00:02, Lin Huang <h...@rock-chips.com> wrote: > Add a driver which support pin multiplexing setup for rk3036 > > Signed-off-by: Lin Huang <h...@rock-chips.com> > --- > Changes in v1: > - clean copyright announcement > Changes in v2: None > Changes in v3: > - fix some coding style error > Changes in v4: None > > drivers/pinctrl/Kconfig | 18 ++ > drivers/pinctrl/rockchip/Makefile | 1 + > drivers/pinctrl/rockchip/pinctrl_rk3036.c | 276 > ++++++++++++++++++++++++++++++ > 3 files changed, 295 insertions(+) > create mode 100644 drivers/pinctrl/rockchip/pinctrl_rk3036.c > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index 3b6e3b7..6495313 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -114,6 +114,24 @@ config ROCKCHIP_PINCTRL > definitions and pin control functions for each available multiplex > function. > > +config ROCKCHIP_3036_PINCTRL > + bool "Rockchip rk3036 pin control driver" > + depends on DM > + help > + Support pin multiplexing control on Rockchip rk3036 SoCs. The > driver is > + controlled by a device tree node which contains both the GPIO > + definitions and pin control functions for each available multiplex > + function. > + > +config ROCKCHIP_PINCTRL
It looks like you are duplicating a config that is already there: > + bool "Rockchip pin control driver" > + depends on DM > + help > + Support pin multiplexing control on Rockchip SoCs. The driver is > + controlled by a device tree node which contains both the GPIO > + definitions and pin control functions for each available multiplex > + function. > + Besides that: Acked-by: Simon Glass <s...@chromium.org> > config PINCTRL_SANDBOX > bool "Sandbox pinctrl driver" > depends on SANDBOX Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot