On 11/16/2015 03:15 PM, Alexey Brodkin wrote:
Hi Stephen,
On Mon, 2015-11-16 at 14:08 -0700, Simon Glass wrote:
Hi,
On 16 November 2015 at 06:47, Alexey Brodkin
<alexey.brod...@synopsys.com> wrote:
Hi Simon, Stephen,
On Fri, 2015-11-13 at 19:03 -0700, Simon Glass wrote:
On 13 November 2015 at 11:23, Alexey Brodkin
<alexey.brod...@synopsys.com> wrote:
Hi Simon,
On Fri, 2015-11-13 at 11:14 -0700, Simon Glass wrote:
Hi Alexey,
On 12 November 2015 at 14:56, Alexey Brodkin
<alexey.brod...@synopsys.com> wrote:
[snip]
Up until now there was no need in those stubs.
But since following commit compilation of U-Boot on ARC is broken:
------------------------>8----------------------
commit 7861204c9af7fec1ea9b41541c272516235a6c93
Author: Stephen Warren <swar...@wwwdotorg.org>
Date: Sat Oct 3 13:56:46 2015 -0600
itest: make memory access work under sandbox
itest accesses memory, and hence must map/unmap it. Without doing so, it
accesses invalid addresses and crashes.
Signed-off-by: Stephen Warren <swar...@wwwdotorg.org>
Reviewed-by: Simon Glass <s...@chromium.org>
------------------------>8----------------------
That's because CMD_ITEST is enabled by default in common/Kconfig and now
map_physmem()/unmap_physmem() is used there.
So this patch adds missing stubs for ARC.
Signed-off-by: Alexey Brodkin <abrod...@synopsys.com>
Cc: Stephen Warren <swar...@wwwdotorg.org>
Cc: Simon Glass <s...@chromium.org>
---
Reviewed-by: Simon Glass <s...@chromium.org>
So should I move map_physmem()/unmap_physmem() in generic header and include
it in asm/io.h for every arch (as suggested by Stephen) or for starters I
may have stubs for ARC and once this patch is accepted do clean-up for
all arches at once?
Either is fine with me. If you do a shared file it should be in
include/asm-generic I think.
Please let me know if you're fine as well with local patch for ARC
for starters. This quick fix is really necessary because as of today
U-Boot for ARC couldn't be built at all from current master branch.
Yes, that seems fine; my suggestion was more for post-patch cleanup.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
