Hi Bin,

On 2015年11月18日 09:07, Bin Meng wrote:
Hi Thomas,

On Mon, Nov 16, 2015 at 10:36 PM, Thomas Chou <tho...@wytron.com.tw> wrote:
Unify serial_x86, and use the generic binding.

Signed-off-by: Thomas Chou <tho...@wytron.com.tw>
---
  arch/x86/Kconfig            |  4 ++++
  arch/x86/dts/serial.dtsi    |  2 +-
  configs/efi-x86_defconfig   |  2 +-
  drivers/serial/Kconfig      | 10 ----------
  drivers/serial/Makefile     |  1 -
  drivers/serial/serial_x86.c | 44 --------------------------------------------
  6 files changed, 6 insertions(+), 57 deletions(-)
  delete mode 100644 drivers/serial/serial_x86.c

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index f92082d..61011c9 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -422,4 +422,8 @@ config PCIE_ECAM_SIZE

  source "arch/x86/lib/efi/Kconfig"

+config NS16550_SERIAL
+       depends on DM_SERIAL
+       default y

I am not in favor of adding driver options to arch Kconfig. I would
suggest updating NS16550_SERIAL option in driver/serial/Kconfig, like
what was done in X86_SERIAL before:

config NS16550_SERIAL
         default y if X86


Thanks for reminding. I was trying to recall how to use this "if". :)

Best regards,
Thomas

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to