On Monday, November 23, 2015 at 01:25:39 PM, Pavel Machek wrote:
> Hi!
>
> > +union dramaddrw_reg {
> > + struct {
> > + u32 cfg_col_addr_width:5;
> > + u32 cfg_row_addr_width:5;
> > + u32 cfg_bank_addr_width:4;
> > + u32 cfg_bank_group_addr_width:2;
> > + u32 cfg_cs_addr_width:3;
> > + u32 reserved:13;
> > + };
> > + u32 word;
> > +};
>
> Umm. Are you sure this is good idea? Is gcc allowed to do something
> funny and reorder bitfields in unexpected way?
GCC won't do anything, but I cannot say I'm a big fan of those bitfields.
Let's just drop them and use the BIT() macro.
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
