Hi Marek, On Fri, 2015-11-20 at 21:48 +0100, Marek Vasut wrote: > On Wednesday, November 18, 2015 at 04:26:21 PM, Alexey Brodkin wrote: > > This driver is meant to be used with any EHCI-compatible host > > controller in case if there's no need for platform-specific > > glue such as setup of controller or PHY's power mode via > > GPIOs etc. > > > > Signed-off-by: Alexey Brodkin <abrod...@synopsys.com> > > Reviewed-by: Simon Glass <s...@chromium.org> > > Reviewed-by: Marek Vasut <ma...@denx.de> > > Cc: Stephen Warren <swar...@nvidia.com> > > --- > > > > Changes compared to v1: > > * Updated commit message with removal of Synopsys board mention > > * Cleaned-up ehci_usb_remove() > > [...] > > > +static int ehci_usb_probe(struct udevice *dev) > > +{ > > + struct ehci_hccr *hccr = (struct ehci_hccr *)dev_get_addr(dev); > > + struct ehci_hcor *hcor; > > + > > + hcor = (struct ehci_hcor *)((uint32_t)hccr + > > This should be uintptr_t for the sake of 64bit systems, no ? > > > + HC_LENGTH(ehci_readl(&hccr->cr_capbase))); > > + > > + return ehci_register(dev, hccr, hcor, NULL, 0, USB_INIT_HOST); > > +} > > I can fix that nit when applying, so let me know what you think please.
Could you please do that fix and apply the patch? -Alexey _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot