On Monday, December 07, 2015 at 01:56:23 PM, Chin Liang See wrote:
> On Sat, 2015-12-05 at 21:44 +0100, Marek Vasut wrote:
> > Drop all the common board code, since it is not completely useless.
> >
> > Signed-off-by: Marek Vasut <ma...@denx.de>
> > Cc: Chin Liang See <cl...@altera.com>
> > Cc: Dinh Nguyen <dingu...@opensource.altera.com>
> > ---
> >
> > board/altera/arria5-socdk/socfpga.c | 56 -------------------------
> >
> > ----------
> >
> > board/altera/cyclone5-socdk/socfpga.c | 56 -------------------------
> >
> > ----------
> >
> > board/denx/mcvevk/socfpga.c | 56 -------------------------
> >
> > ----------
> >
> > board/ebv/socrates/socfpga.c | 56 -------------------------
> >
> > ----------
> >
> > board/sr1500/socfpga.c | 17 -----------
> > board/terasic/de0-nano-soc/socfpga.c | 16 ----------
> > board/terasic/sockit/socfpga.c | 56 -------------------------
> >
> > ----------
> >
> > 7 files changed, 313 deletions(-)
> >
> > diff --git a/board/altera/arria5-socdk/socfpga.c
> > b/board/altera/arria5-socdk/socfpga.c
> > index 449f3b5..97fb902 100644
> > --- a/board/altera/arria5-socdk/socfpga.c
> > +++ b/board/altera/arria5-socdk/socfpga.c
> > @@ -3,60 +3,4 @@
> >
> > *
> > * SPDX-License-Identifier: GPL-2.0+
> > */
> >
> > -
> >
> > #include <common.h>
> >
> > -#include <errno.h>
> > -#include <asm/arch/reset_manager.h>
> > -#include <asm/io.h>
> > -
> > -#include <usb.h>
> > -#include <usb/dwc2_udc.h>
> > -
> > -DECLARE_GLOBAL_DATA_PTR;
> > -
> > -void s_init(void) {}
> > -
> > -/*
> > - * Miscellaneous platform dependent initialisations
> > - */
> > -int board_init(void)
> > -{
> > - /* Address of boot parameters for ATAG (if ATAG is used) */
> > - gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100;
> > -
> > - return 0;
> > -}
>
> Suggesting to keep the board_init function where user can put board
> specific initialization here.
If the need for that ever arises, you can make the board_init in board.c
__weak and override it here. But there should be no need for any board
specific init, the DT should be the only place where such things should
be described.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
