On Sat, 2015-12-12 at 22:45 +0100, Marek Vasut wrote: > On Saturday, December 12, 2015 at 10:10:00 PM, Pavel Machek wrote: > > On Fri 2015-12-11 17:15:50, Chin Liang See wrote: > > > Enabling mtd partitioning layout which indicate partition > > > for various boot partition > > > > > > Signed-off-by: Chin Liang See <cl...@altera.com> > > > Cc: Dinh Nguyen <dingu...@opensource.altera.com> > > > Cc: Dinh Nguyen <dinh.li...@gmail.com> > > > Cc: Pavel Machek <pa...@denx.de> > > > Cc: Marek Vasut <ma...@denx.de> > > > Cc: Stefan Roese <s...@denx.de> > > > --- > > > > > > include/configs/socfpga_de0_nano_soc.h | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/include/configs/socfpga_de0_nano_soc.h > > > b/include/configs/socfpga_de0_nano_soc.h index 16e146c..c42175d > > > 100644 > > > --- a/include/configs/socfpga_de0_nano_soc.h > > > +++ b/include/configs/socfpga_de0_nano_soc.h > > > @@ -86,4 +86,16 @@ > > > > > > /* The rest of the configuration is shared */ > > > #include <configs/socfpga_common.h> > > > > > > +/* mtd partitioning for serial NOR flash */ > > > +#if defined(CONFIG_CMD_UBI) || defined(CONFIG_CMD_SF) > > > +#define MTDPARTS_DEFAULT "mtdparts=ff705000.spi:"\ > > > + "256k(spl)," \ > > > + "64k(env)," \ > > > + "64k(dtb)," \ > > > + "256k(boot)," \ > > > + "16m(kernel)," \ > > > + "16m(rootfs)," \ > > > + "-(UBI)\0" > > > +#endif > > > + > > > > > > #endif /* __CONFIG_TERASIC_DE0_H__ */ > > > > Ok, three copies of the same table. Should it go to socfpga common? > > You could at least do > > > > MTDPARTS_DEFAULT_SOCDK > > > > and then use > > > > #define MTDPARTS_DEFAULT MTDPARTS_DEFAULT_SOCDK > > > > in the socfpga_de0_nano_soc.h, so we don't have 3 copies of the > > same > > table. > > I'd rather suggest to do something like > > #ifndef MTDPARTS_DEFAULT > #define ... > #endif > > in socfpga_common.h . Even better would obviously be if we could just > scrap > this altogether and parse the MTD layout from OF. I dunno if we can > do that > nowadays, but that'd be great. >
Yah this sound good. Let me do that by having them definied into socfpga_common.h Thanks Chin Liang > Best regards, > Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
