Hi Marek,
On 2015年12月24日 13:37, Marek Vasut wrote:
On Thursday, December 24, 2015 at 06:24:45 AM, Thomas Chou wrote:
Hi Marek,
On 2015年12月24日 11:42, Marek Vasut wrote:
On Thursday, December 24, 2015 at 04:26:57 AM, Thomas Chou wrote:
Hi Marek,
Hi Thomas,
On 2015年12月24日 11:02, Marek Vasut wrote:
On Thursday, December 24, 2015 at 03:50:57 AM, Thomas Chou wrote:
Hi Marek,
On 2015年12月24日 09:29, Marek Vasut wrote:
On Thursday, December 24, 2015 at 01:51:23 AM, Thomas Chou wrote:
Show sector erase progress with dot and comma.
Signed-off-by: Thomas Chou <tho...@wytron.com.tw>
---
Shouldn't this go into common code ?
The code to print a dot is minimal. It will cost more if this go into
common code.
But then this driver behaves in a non-standard manner AND noone
benefits from this functionality but this driver.
The sector erase might take very long when there are a lot of sectors to
erase, say 12 min to 50 min for 1024 sectors on the 10m50 board. Without
the display of progress, it will look like the board hangs.
Yeah, that I do understand and I agree this is a good idea :)
The dotting code comes from the old cfi_flash.c. Some other parallel
flash have this, but not spi-flash. It is trivial to add though.
Urm, altera_qspi is CFI, right ? So can we stuff this into common code or
not? Sorry if I am confused and off the mark.
No worries. I think the dotting is best done per driver.
Well why do you think so ?
Well, it is only a putc() which is plain and simple.
Best regards,
Thomas
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
