Hi Sjoerd, On 1 October 2015 at 03:48, Sjoerd Simons <sjoerd.sim...@collabora.co.uk> wrote: > > > This series adds support for the GMAC Ethernet interface on RK3288 SoCs. > > To add support I've taken a slightly different approach then some of the > other boards with a designware IP block, by creating a new driver to > take care of the platfrom glue which subclasses the main designware driver > instead of adding the compatibility string the designware driver > directly and doing the SoC specific setup in the board files. This seems > quite a bit more elegant in a device model based world. > > As the pinctrl and clock drivers are quite simple at the moment > (hardcoded settings rather then retrieved from device-tree) the pinctrl > and clock settings added in this series assume the setup for the > ethernet interface used is for Firefly and Radxa Rock 2. Specifically It > assumes the gmac is driven by an external clock, GPIO4B0 is the phy > reset and the phy interface mode is RGMII. > > I've only tested this series on a Radxa Rock 2 board, it would be great > if someone could test this on other boards with the designware IP > especially for those with the reset GPIO in devicetree (e.g. some of the > Allwinner boards). > > > > Sjoerd Simons (10): > rockchip: rk3288: Add pinctrl support for the gmac ethernet interface > rockchip: rk3288: Add clock support for the gmac ethernet interface > net: designware: support phy reset device-tree bindings > net: designware: Export various functions/struct to allow subclassing > net: designware: Add a post-started hook > net: gmac_rk3288: Add RK3288 GMAC driver > rockchip: rk3288-firefly: Add gmac definition > rockchip: firefly: Enable networking support > rockchip: Add PXE and DHCP to the default boot targets > rockchip: Drop Ethernet from the TODO > > arch/arm/dts/rk3288-firefly.dtsi | 16 ++ > arch/arm/include/asm/arch-rockchip/cru_rk3288.h | 17 ++ > arch/arm/include/asm/arch-rockchip/grf_rk3288.h | 228 > ++++++++++++++++++++++++ > arch/arm/include/asm/arch-rockchip/periph.h | 1 + > configs/firefly-rk3288_defconfig | 5 + > doc/README.rockchip | 1 - > drivers/clk/clk_rk3288.c | 16 ++ > drivers/net/Kconfig | 7 + > drivers/net/Makefile | 1 + > drivers/net/designware.c | 91 ++++++++-- > drivers/net/designware.h | 19 ++ > drivers/net/gmac_rk3288.c | 140 +++++++++++++++ > drivers/pinctrl/rockchip/pinctrl_rk3288.c | 102 +++++++++++ > include/configs/firefly-rk3288.h | 3 + > include/configs/rk3288_common.h | 4 +- > 15 files changed, 639 insertions(+), 12 deletions(-) > create mode 100644 drivers/net/gmac_rk3288.c >
Are you planning to respin this series? I'd like to pick it up for rockchip at some point. There were a few comments I think, mostly minor. FYI there is some additional work at u-boot-rockchip/rkd-working. It includes some pinctrl and clock additions that might be useful. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot