On 01/12/2016 05:59 PM, Daniel Schwierzeck wrote: > 2016-01-12 11:18 GMT+01:00 Purna Chandra Mandal <purna.man...@microchip.com>: >> Signed-off-by: Purna Chandra Mandal <purna.man...@microchip.com> >> --- >> >> Changes in v3: None >> Changes in v2: None >> >> arch/mips/cpu/start.S | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/mips/cpu/start.S b/arch/mips/cpu/start.S >> index e95cdca..35d9650 100644 >> --- a/arch/mips/cpu/start.S >> +++ b/arch/mips/cpu/start.S >> @@ -185,6 +185,8 @@ reset: >> PTR_ADDU t0, k0, GD_MALLOC_BASE # gd->malloc_base offset >> sw sp, 0(t0) >> #endif >> + /* Initialize args to zero */ >> + move a0, zero > the comment should be on the same line and more precise. That is > useful in disassemblies or when debugging. E.g. > > move a0, zero # a0 <-- boot_flags = 0 > > Also add a commit message please explaining why the change is > required. Something like that the boot_flags of board_init_f should be > set to 0 because $a0 may be utilized in lowlevel_init or > mips_cache_reset.
ack. Will add accordingly, >> PTR_LA t9, board_init_f >> jr t9 >> -- >> 1.8.3.1 >> > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
