On Mon, Dec 28, 2015 at 08:02:26AM -0500, Robert P. J. Day wrote:
>
> currently poking around in drivers/block, adding a driver for
> another silicon image drive, and noticed that sata_sil3114.h has some
> content that looks more appropriate for a generic ATA/SATA header
> file.
>
> for example, this snippet:
>
> /* Missing ata defines */
> #define ATA_CMD_STANDBY 0xE2
> #define ATA_CMD_STANDBYNOW1 0xE0
> #define ATA_CMD_IDLE 0xE3
> #define ATA_CMD_IDLEIMMEDIATE 0xE1
>
> seems already covered by include/libata.h, while the earlier structure
> definitions in that file:
>
> struct sata_ioports {
> ... snip ...
> };
>
> struct sata_port {
> ... snip ...
> };
>
> also look like they could be moved to a generic SATA-related header
> file. does that make any sense or sound like it has any value?Less stuff in files will make DM easier eventually so yes. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
