Hi Simon, Some minor comments below. Otherwise
Acked-by: Anatolij Gustschin <ag...@denx.de> On Tue, 5 Jan 2016 09:31:01 -0700 Simon Glass <s...@chromium.org> wrote: ... > +config VIDEO_BPP8 > + bool "Support 8-bit-per-pixel displays" > + depends on DM_VIDEO > + default y if DM_VIDEO > + help > + Support drawing text and bitmaps onto a 8-bit-per-pixel display. > + Ebabling this will include code to support this display. Without s/Ebabling/Enabling/ > +config VIDEO_BPP16 > + bool "Support 16-bit-per-pixel displays" > + depends on DM_VIDEO > + default y if DM_VIDEO > + help > + Support drawing text and bitmaps onto a 16-bit-per-pixel display. > + Ebabling this will include code to support this display. Without same typo here. > +config VIDEO_BPP32 > + bool "Support 32-bit-per-pixel displays" > + depends on DM_VIDEO > + default y if DM_VIDEO > + help > + Support drawing text and bitmaps onto a 32-bit-per-pixel display. > + Ebabling this will include code to support this display. Without s/Ebabling/Enabling/ ... > +/** > + * struct video_priv - Device information used by the video uclass > + * > + * @xsize: Number of pixel columns (e.g. 1366) > + * @ysize: Number of pixels rows (e.g.. 768) > + * @tor: Display rotation (0=none, 1=90 degrees clockwise, etc.) > + * @bpix: Encoded bits per pixel > + * @fb: Frame buffer > + * @fb_size: Frame buffer size > + * @fb_size: Frame buffer size Please remove duplicated line here. ... > +/** > + * video_get_xsize() - Get the height of the display in pixels s/_xsize/_ysize/ Thanks, Anatolij _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
