> -----Original Message-----
> From: Mingkai Hu
> Sent: Friday, January 29, 2016 11:03 AM
> To: Qiang Zhao <qiang.z...@nxp.com>
> Cc: tr...@konsulko.com; york sun <york....@nxp.com>; u-boot@lists.denx.de;
> Qiang Zhao <qiang.z...@nxp.com>
> Subject: RE: [PATCH v3 4/4] qe: assgin pins to qe-hdlc
>
> > -----Original Message-----
> > From: Zhao Qiang [mailto:qiang.z...@nxp.com]
> > Sent: Friday, January 29, 2016 10:51 AM
> > To: Mingkai Hu
> > Cc: tr...@konsulko.com; york sun; u-boot@lists.denx.de; Qiang Zhao
> > Subject: [PATCH v3 4/4] qe: assgin pins to qe-hdlc
> >
> > qe-hdlc and usb multi-use the pins, when set hwconfig=qe-hdlc, assign
> > the pins to qe-hdlc, if not, assgin it to usb
> >
> > Signed-off-by: Zhao Qiang <qiang.z...@nxp.com>
> > ---
> > int ft_board_setup(void *blob, bd_t *bd) {
> > u64 base[CONFIG_NR_DRAM_BANKS];
> > @@ -169,6 +185,21 @@ int ft_board_setup(void *blob, bd_t *bd) #ifdef
> > CONFIG_SYS_DPAA_FMAN
> > fdt_fixup_fman_ethernet(blob);
> > #endif
> > +
> > + /* qe-hdlc and usb multi-use the pins,
> > + * when set hwconfig to qe-hdlc, delete usb node.
> > + */
>
> Use multiple lines comments.
> /*
> *
> */
Thank you! I will change it in next version.
>
> > + if (hwconfig("qe-hdlc"))
> > +#ifdef CONFIG_HAS_FSL_XHCI_USB
> > + fdt_del_node_and_alias(blob, "usb1"); #endif
> > + /* qe just support qe-uart and qe-hdlc,
> > + * if qe-uart and qe-hdlc are not set in hwconfig,
> > + * delete qe node.
> > + */
>
> Ditto.
Thank you! I will change it in next version.
Best Regards
Zhao Qiang
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
