On Friday 21 August 2009 02:05:47 Simon Kagstrom wrote: > On Thu, 20 Aug 2009 13:44:35 -0400 Mike Frysinger wrote: > > On Thursday 20 August 2009 04:52:50 Simon Kagstrom wrote: > > > --- a/include/asm-sh/bitops.h > > > +++ b/include/asm-sh/bitops.h > > > @@ -146,6 +146,11 @@ static inline int ffs (int x) > > > } > > > return r; > > > } > > > + > > > +#define __set_bit(nr, addr) generic_set_bit(nr, addr) > > > + > > > +#define __clear_bit(nr, addr) generic_clear_bit(nr, addr) > > > > this is just silly to put into every arch header. why not do in the > > common code: > > #ifndef __set_bit > > # define __set_bit generice_set_bit > > #endif > > It's a function (static inline) in some architectures.
add the obvious #define i already posted in a later e-mail. it makes a lot more sense for the non-common behavior of providing a custom implementation to add one more line per func than to try and update (and keep up-to-date) every arch using the common code. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
