Dear Timur Tabi,
In message <1250542538-5717-1-git-send-email-ti...@freescale.com> you wrote:
> The Intel E1000 driver was making assumptions about the relationship between
> some virtual, physical, and PCI addresses.
>
> Also fix some bad usage of the DEBUGOUT macro
>
> Signed-off-by: Timur Tabi <ti...@freescale.com>
> ---
> drivers/net/e1000.c | 17 +++++++++--------
> 1 files changed, 9 insertions(+), 8 deletions(-)
This patch causes compiler warnings:
Configuring for MVBC_P board...
e1000.c: In function 'e1000_transmit':
e1000.c:5019: warning: passing argument 1 of 'virt_to_phys' discards
qualifiers from pointer target type
...
Configuring for MPC8536DS board...
e1000.c: In function 'e1000_transmit':
e1000.c:5019: warning: passing argument 1 of 'virt_to_phys' discards
qualifiers from pointer target type
...
Configuring for MPC8544DS board...
e1000.c: In function 'e1000_transmit':
e1000.c:5019: warning: passing argument 1 of 'virt_to_phys' discards
qualifiers from pointer target type
...
etc.
Please provide a fix!
Also, I tonticed this:
> @@ -357,7 +356,7 @@ e1000_acquire_eeprom(struct e1000_hw *hw)
> struct e1000_eeprom_info *eeprom = &hw->eeprom;
> uint32_t eecd, i = 0;
>
> - DEBUGOUT();
> + DEBUGFUNC();
>
> if (e1000_swfw_sync_acquire(hw, E1000_SWFW_EEP_SM))
> return -E1000_ERR_SWFW_SYNC;
> @@ -418,7 +417,7 @@ static int32_t e1000_init_eeprom_params(struct e1000_hw
> *hw)
> int32_t ret_val = E1000_SUCCESS;
> uint16_t eeprom_size;
>
> - DEBUGOUT();
> + DEBUGFUNC();
...
These changes are unrelated to the change and not even mentioned in
the commit message. This is a bad thing to do. Please make sure NOT
to do this again. Please split this into two orthogonal patches next
time. Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Very ugly or very beautiful women should be flattered on their
understanding, and mediocre ones on their beauty.
-- Philip Earl of Chesterfield
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
