On 02/26/2016 05:07 PM, Sriram Dash wrote: > Please find my reply inline
Please stop top-posting. Also please fix your mailer so it quotes correctly with '>' > -----Original Message----- From: Marek Vasut [mailto:ma...@denx.de] > Sent: Thursday, February 25, 2016 11:28 PM To: Sriram Dash > <sriram.d...@nxp.com>; u-boot@lists.denx.de Cc: york sun > <york....@nxp.com>; Ramneek Mehresh <ramneek.mehr...@nxp.com>; Rajesh > Bhagat <rajesh.bha...@nxp.com> Subject: Re: [PATCH v2 1/2] > board:freescale:common: Move device-tree fixup framework to common > file > > On 02/24/2016 05:44 AM, Sriram Dash wrote: >> Move usb device-tree fixup framework from ehci-fsl.c to common >> place so that it can be used by other drivers as well >> (xhci-fsl.c). Also, call fdt_usb_get_node_type() from >> fdt_fixup_usb_mode_phy_type() to avoid code duplication. >> >> Signed-off-by: Ramneek Mehresh <ramneek.mehr...@nxp.com> >> Signed-off-by: Sriram Dash <sriram.d...@nxp.com> > > Is this just moving the code ? If so, please resubmit and use git > format-patch -M -C to generate the patches for the submission. It > makes it much easier to detect moved files. > > [Sriram] No, this patch is performing two actions: > > 1. Move usb device-tree fixup framework from ehci-fsl.c to common > place so that it can be used by other drivers as well (xhci-fsl.c). > > 2. Call fdt_usb_get_node_type() from fdt_fixup_usb_mode_phy_type() to > avoid code duplication. Then it should be two patches. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot