On Fri, Feb 26, 2016 at 12:17 PM, Tom Rini <tr...@konsulko.com> wrote: > On Thu, Feb 25, 2016 at 12:53:43PM -0600, Nishanth Menon wrote: > >> '#define X a | b' is better defined as '#define X (a | b)' for obvious >> reasons. >> >> Signed-off-by: Nishanth Menon <n...@ti.com> > > Reviewed-by: Tom Rini <tr...@konsulko.com> > > But this makes my head hurt. Can we somehow do any of that with less > parenthesis? Like, is this really something we must macro? Or can we > re-factor it? I had to highlight every open/close to be happy it was > correct, which is not a good sign.
I will try and give it a shot and repost - yeah - it was pretty convoluted in the first place might be changing it to a static inline might be a simpler approach.. -- --- Regards, Nishanth Menon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
