On Sun, Apr 24, 2016 at 08:50:01AM +0200, Beniamino Galvani wrote:

> This adds platform code for the Amlogic Meson GXBaby (S905) SoC and a
> board definition for ODROID-C2. This initial submission only supports
> UART and Ethernet (through the existing Designware driver). DTS files
> are the ones submitted to Linux arm-soc for 4.7 [1].
> 
> [1] https://patchwork.ozlabs.org/patch/603583/
> 
> Signed-off-by: Beniamino Galvani <b.galv...@gmail.com>
[snip]
> +#if !defined(CONFIG_IDENT_STRING)
> +# define CONFIG_IDENT_STRING         " odroid-c2"
> +#endif

Would this ever already be set?

> +/* Serial setup */
> +#define CONFIG_CONS_INDEX            0
> +#define CONFIG_BAUDRATE                      115200
> +#define CONFIG_SYS_BAUDRATE_TABLE \
> +     { 4800, 9600, 19200, 38400, 57600, 115200 }

And I assume you could live with the default table really.

Otherwise looks good, thanks.

-- 
Tom

Attachment: signature.asc
Description: Digital signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to