Hi Simon, > -----Original Message----- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: 2016年5月6日 1:19 > To: Yang, Wenyou <wenyou.y...@atmel.com> > Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Joe Hershberger > <joe.hershber...@ni.com>; h...@denx.de > Subject: Re: [U-Boot] [PATCH 07/18] net: macb: Convert to driver model > > Hi, > > On 4 May 2016 at 21:37, Yang, Wenyou <wenyou.y...@atmel.com> wrote: > > Hi, > > > > > > On 2016/5/5 11:18, Simon Glass wrote: > > > > Hi, > > > > On May 4, 2016 21:15, "Yang, Wenyou" <wenyou.y...@atmel.com> wrote: > >> > >> Hi Simon, > >> > >> > -----Original Message----- > >> > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon > >> > Glass > >> > Sent: 2016年5月5日 10:38 > >> > To: Yang, Wenyou <wenyou.y...@atmel.com> > >> > Cc: h...@denx.de; U-Boot Mailing List <u-boot@lists.denx.de>; Joe > >> > Hershberger <joe.hershber...@ni.com> > >> > Subject: Re: [U-Boot] [PATCH 07/18] net: macb: Convert to driver > >> > model > >> > > >> > Hi, > >> > > >> > On 4 May 2016 at 01:32, Yang, Wenyou <wenyou.y...@atmel.com> wrote: > >> > > > >> > > Hi > >> > > > >> > > > -----Original Message----- > >> > > > From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of > >> > > > Heiko Schocher > >> > > > Sent: 2016年5月3日 15:54 > >> > > > To: Simon Glass <s...@chromium.org> > >> > > > Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Joe Hershberger > >> > > > <joe.hershber...@ni.com> > >> > > > Subject: Re: [U-Boot] [PATCH 07/18] net: macb: Convert to > >> > > > driver model > >> > > > > >> > > > Hello Simon, > >> > > > > >> > > > Am 03.05.2016 um 08:40 schrieb Simon Glass: > >> > > > > Add driver-model support to this driver. The old code remains > >> > > > > for now so that we can convert boards one at a time. > >> > > > > > >> > > > > Signed-off-by: Simon Glass <s...@chromium.org> > >> > > > > --- > >> > > > > > >> > > > > drivers/net/macb.c | 119 > >> > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++ > >> > > > > 1 file changed, 119 insertions(+) > >> > > > > >> > > > Thanks! > >> > > > > >> > > > Reviewed-by: Heiko Schocher <h...@denx.de> > >> > > > > >> > > > tested on the smartweb, corvus, taurus and axm board > >> > > > > >> > > > Tested-by: Heiko Schocher <h...@denx.de> > >> > > > >> > > I tried to test this patch series on SAMA5D2 Xplained board, but > >> > > I have the > >> > compile warning below. Did you experience it? > >> > > > >> > > ---8<--------- > >> > > drivers/net/macb.c: In function 'macb_phy_init': > >> > > drivers/net/macb.c:487:9: warning: passing argument 3 of 'phy_connect' > >> > > from incompatible pointer type [enabled by default] In file > >> > > included from > >> > include/miiphy.h:22:0, > >> > > from drivers/net/macb.c:36: > >> > > include/phy.h:226:20: note: expected 'struct udevice *' but > >> > > argument is of type > >> > 'const struct device **' > >> > > --->8-------- > >> > > >> > No I don't see that problem. I did a full build test. What is the > >> > board config name you are using? > >> > >> The board is SAMA5D2 Xplained board, the .config file is attached. > >> > >> I noticed that in include/phy.h file, phy_connect() has different > >> prototype for enabling CONFIG_DM_ETH or not. > >> > >> So, I think this issue should be exist. > > > > Is that board in mainline? > > > > Yes, in mainline. > > > > The type of 'dev' parameter of phy_connect() is struct udevice *, > > instead of struct eth_device * when enabling CONFIG_DM_ETH. > > OK, sounds like it needs a patch. Can you fix it when you enable DM_ETH for > that > board?
Okay, I will try to fix it. Best Regards, Wenyou Yang _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
