On Fri, May 13, 2016 at 10:00:37PM +0800, Bin Meng wrote:
> Hi Miao,
> 
> On Fri, May 13, 2016 at 2:29 PM, Miao Yan <yanmiaob...@gmail.com> wrote:
> > The qfw command interface makes use of CONFIG_LOADADDR and
> > CONFIG_RAMDISKADDR to setup kernel. But not all boards have these macro,
> > which causes build problem on those platforms.
> >
> > This patch fixes this issue.
> >
> > Signed-off-by: Miao Yan <yanmiaob...@gmail.com>
> 
> Looks good.
> 
> Reviewed-by: Bin Meng <bmeng...@gmail.com>
> 
> But the commit title "workaround" looks to be a workaround, which does
> not sound that good.

Yes, maybe just say that it's no longer requiring default values?

-- 
Tom

Attachment: signature.asc
Description: Digital signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to