Hi Simon, On 05.05.16 15:28, Simon Glass wrote: > The code does not compile if ECC is enabled. > > Signed-off-by: Andre Renaud <aren...@bluewatersys.com> > Signed-off-by: Simon Glass <s...@chromium.org> > --- > > Changes in v2: None > > drivers/mtd/nand/atmel_nand.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c > index 8fac824..15958cb 100644 > --- a/drivers/mtd/nand/atmel_nand.c > +++ b/drivers/mtd/nand/atmel_nand.c > @@ -20,6 +20,8 @@ > #include <watchdog.h> > #include <linux/mtd/nand_ecc.h> > > +#define dev_warn(dev, msg...) > +
This change is good in general, but I think the better fix is to use dev_err() for the uncorrectable error and dev_dbg() for the rest. Andreas > #ifdef CONFIG_ATMEL_NAND_HWECC > > /* Register access macros */ > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
