On 1 July 2016 at 14:22, Oleksandr Tymoshenko <go...@bluezbox.com> wrote: > Return value of rtl_send_common propogates unmodified all the way > up to eth_send and further to API consumer if CONFIG_API is enabled. > Previously rtl_send_common returned number of bytes sent on success > which was erroneouly detected as error condition by API consumers > that checked for operation success by comparing return value with 0. > > Switch rtl_send_common to use common convention: return 0 on success > and negative value for failure. > > Cc: Stephen Warren <swar...@nvidia.com> > Cc: Joe Hershberger <joe.hershber...@ni.com> > Signed-off-by: Oleksandr Tymoshenko <go...@bluezbox.com> > --- > drivers/net/rtl8169.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <s...@chromium.org> But I'd like to see a function comment on rtl_send_common(), and on the driver-model send() method in struct eth_ops, for that matter. - Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
