Hi, On 29 July 2016 at 02:00, Jaehoon Chung <jh80.ch...@samsung.com> wrote: > Hi Kever, > > On 07/29/2016 11:35 AM, Kever Yang wrote: >> This patch add driver for: >> - clock driver including set_rate for cpu, mmc, vop, I2C. >> - sysreset driver >> - grf syscon driver >> >> Signed-off-by: Kever Yang <kever.y...@rock-chips.com> > > I don't have a knowledge for rockchip..So i don't add the comments relevant > to rockchip. > Just add the general comments. > >> --- >> >> Changes in v2: >> - include '_SHIFT_' in '_MASK' MACRO >> - fix comment style >> - use DIV_ROUND_UP instead of div_round_up >> - use uclass_get_device_by_driver in rockchip_get_cru >> - implement ofdata_to_platdata for priv->cru init >> >> arch/arm/include/asm/arch-rockchip/cru_rk3399.h | 93 +++ >> arch/arm/mach-rockchip/rk3399/Makefile | 2 + >> arch/arm/mach-rockchip/rk3399/reset_rk3399.c | 45 ++ >> arch/arm/mach-rockchip/rk3399/syscon_rk3399.c | 20 + >> drivers/clk/Makefile | 1 + >> drivers/clk/clk_rk3399.c | 819 >> ++++++++++++++++++++++++ >> 6 files changed, 980 insertions(+) >> create mode 100644 arch/arm/include/asm/arch-rockchip/cru_rk3399.h >> create mode 100644 arch/arm/mach-rockchip/rk3399/reset_rk3399.c >> create mode 100644 arch/arm/mach-rockchip/rk3399/syscon_rk3399.c >> create mode 100644 drivers/clk/clk_rk3399.c
Apart from the error numbers as pointed out: Acked-by: Simon Glass <s...@chromium.org> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
