Hi Stephen, On Mon, Oct 10, 2016 at 6:07 PM, Stephen Warren <swar...@wwwdotorg.org> wrote: > On 09/23/2016 11:43 AM, Joe Hershberger wrote: >> >> On Fri, Sep 23, 2016 at 11:31 AM, Stephen Warren <swar...@wwwdotorg.org> >> wrote: >>> >>> On 09/15/2016 01:20 PM, Joe Hershberger wrote: >>>> >>>> >>>> On Thu, Sep 15, 2016 at 1:53 PM, Stephen Warren <swar...@wwwdotorg.org> >>>> wrote: >>>>> >>>>> >>>>> From: Stephen Warren <swar...@nvidia.com> >>>>> >>>>> eth-uclass.c expects DM-capable Ethernet adapters to implement ops-> >>>>> read_rom_hwaddr(), or for some other mechanism to set pdata->enetaddr, >>>>> or >>>>> for the user to set environment variable $usbethaddr. Without any of >>>>> these, it will refuse to initialize the device since no valid MAC >>>>> address >>>>> is known. Implement this function for the smsc95xx driver. >>>>> >>>>> With this feature implemented, there is no point smsc95xx_init_common() >>>>> re-reading the MAC address from ROM, so ifdef out this code when DM_ETH >>>>> is enabled. >>>>> >>>>> This allows (at least) the built-in Ethernet on the NVIDIA Harmony >>>>> board >>>>> to operate again. >>>>> >>>>> Fixes: 0990fcb77219 ("net: smsc95xx: Add driver-model support") >>>>> Signed-off-by: Stephen Warren <swar...@nvidia.com> >>>> >>>> >>>> >>>> Acked-by: Joe Hershberger <joe.hershber...@ni.com> >>> >>> >>> >>> Joe, was that ack just so you remember you've reviewed this when you come >>> to >>> applying patches later, or was it a signal to someone else that they >>> should >>> apply it? >> >> >> No, I'll pull it in. > > > Joe, I can't find this applied anywhere yet.
Sorry about that. I've got it and all other acked patches assigned to me in a build test. Hopefully tomorrow I'll be able to send a pull request, but it's a bit up in the since I've already seen some warnings added by at least one of the patches. :/ -Joe _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot