On Fri, Nov 04, 2016 at 08:18:29PM +0100, Cédric Schieli wrote: > 2016-11-04 19:04 GMT+01:00 Tom Rini <tr...@konsulko.com>: > > > > At U-Boot entry point, the r2 register holds the address of the > > > firmware provided boot param. Let's save it for further processing. > > > > > > Signed-off-by: Cédric Schieli <cschi...@gmail.com> > > [snip] > > > diff --git a/include/configs/rpi.h b/include/configs/rpi.h > > > index 8d4ad5d..2d1e619 100644 > > > --- a/include/configs/rpi.h > > > +++ b/include/configs/rpi.h > > > @@ -208,5 +208,9 @@ > > > ENV_MEM_LAYOUT_SETTINGS \ > > > BOOTENV > > > > > > +#ifndef __ASSEMBLY__ > > > +/* Firmware provided boot param */ > > > +extern const void *fw_boot_param; > > > +#endif > > > > This is not a good place to hold this. Looking at 2/2, just put this > > into the board file and comment above it that it's declared in > > lowlevel_init.S. > > That's where I've put it in the first place, but patmat complained about > externs in .c file... > I'll adress that in the next version.
OK. Yes, in this case it's better to ignore that warning than to throw it into config.h. If there was already an rpi.h, it should go in there. I suppose that it's probably best overall to create an rpi.h and put it in there. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
