On 11/08/2016 10:04 PM, Shengzhou Liu wrote: >> > If we keep A009942 workaround in fsl_ddr_gen4.c, > 1) we have to duplicate 3 same implement of A009942 separately in > mpc85xx_ddr_gen3.c, arm_ddr_gen3.c and fsl_ddr_gen4.c, that is not a good > idea. > 2) we have to modify more code struct to introduce memctl_options_t *popts > pointer in mpc85xx_ddr_gen3.c, arm_ddr_gen3.c and fsl_ddr_gen4.c to configure > new option popts->cpo_sample. > You had added ERRATUM_A004508 in ctrl_regs.c instead of in hardware > interface, so as a special A009942, we can do it as well. > Actually I had carefully thought of what you mentioned concerns before I > decided to move A009942 and A008378(only for debug[28]) to common > ctrl_regs.c. for future erratum and other registers except debug[28], we > still keep them in files of hardware interface. >
OK. Thanks for the explanation. York _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
