On Sat, Nov 5, 2016 at 9:37 PM, Simon Glass <s...@chromium.org> wrote: > Hi Jagan, > > On 30 October 2016 at 11:46, Jagan Teki <ja...@openedev.com> wrote: >> - Move headers froms sf_params to common header file >> - Removed unnecessary comment >> >> Cc: Simon Glass <s...@chromium.org> >> Cc: Bin Meng <bmeng...@gmail.com> >> Cc: York Sun <york....@nxp.com> >> Cc: Vignesh R <vigne...@ti.com> >> Cc: Mugunthan V N <mugunthan...@ti.com> >> Cc: Michal Simek <michal.si...@xilinx.com> >> Cc: Siva Durga Prasad Paladugu <siva...@xilinx.com> >> Signed-off-by: Jagan Teki <ja...@openedev.com> >> --- >> drivers/mtd/spi/sf_internal.h | 5 +++-- >> drivers/mtd/spi/sf_params.c | 5 ----- >> 2 files changed, 3 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/mtd/spi/sf_internal.h b/drivers/mtd/spi/sf_internal.h >> index 71feba9..4a88cf7 100644 >> --- a/drivers/mtd/spi/sf_internal.h >> +++ b/drivers/mtd/spi/sf_internal.h >> @@ -10,8 +10,9 @@ >> #ifndef _SF_INTERNAL_H_ >> #define _SF_INTERNAL_H_ >> >> -#include <linux/types.h> >> -#include <linux/compiler.h> >> +#include <common.h> >> +#include <spi.h> >> +#include <spi_flash.h> > > No, these headers should remain in the C file that needs them. > Transitive include should be minimised.
OK, will skip this patch. thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot