On Tue, 2016-11-22 at 16:22 +0100, Marek Vasut wrote: > On 11/22/2016 03:48 PM, Christoph Fritz wrote:
[...] > > diff --git a/board/samtec/vining2000/imximage.cfg > > b/board/samtec/vining2000/imximage.cfg > > new file mode 100644 > > index 0000000..4133dda > > --- /dev/null > > +++ b/board/samtec/vining2000/imximage.cfg > > @@ -0,0 +1,132 @@ > > +/* > > + * Copyright (C) 2016 samtec automotive software & electronics gmbh > > + * > > + * SPDX-License-Identifier: GPL-2.0+ > > + */ > > + > > +#define __ASSEMBLY__ > > +#include <config.h> > > Is this needed at all ? yes > > +{ > > + unsigned char offset, i, switch_num; > > + u32 id; > > + int ret; > > + > > + pmic_reg_read(p, PFUZE100_DEVICEID, &id); > > + id = id & 0xf; > > + > > + if (id == 0) { > > + switch_num = 6; > > + offset = PFUZE100_SW1CMODE; > > + } else if (id == 1) { > > + switch_num = 4; > > + offset = PFUZE100_SW2MODE; > > + } else { > > + printf("Not supported, id=%d\n", id); > > + return -EINVAL; > > + } > > + > > + ret = pmic_reg_write(p, PFUZE100_SW1ABMODE, mode); > > Why do you need to do this write ? to init the PMIC mode to APS_PFM [...] > > +int board_phy_config(struct phy_device *phydev) > > +{ > > + if (phydev->drv->config) > > + phydev->drv->config(phydev); > > Is this really needed? no [...] Thanks, I'll reroll this patch. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot