On 09.12.2016 14:38, Phil Edworthy wrote:
This device also works with the 88E1518 code, so we just adjust
the UID mask accordingly.

Signed-off-by: Phil Edworthy <phil.edwor...@renesas.com>
---
v2:
 Don't add a new entry, just adjust the UID mask.
---
 drivers/net/phy/marvell.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index 95d1492..5adfe7d 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -585,10 +585,14 @@ static struct phy_driver M88E1510_driver = {
        .shutdown = &genphy_shutdown,
 };

+/* This supports:
+ *  88E1518, uid 0x1410dd1
+ *  88E1512, uid 0x1410dd4
+ */

Nitpicking comment:

Please use this multiline comment style:

/*
 * This supports:
 *  88E1518, uid 0x1410dd1
 *  88E1512, uid 0x1410dd4
 */

 static struct phy_driver M88E1518_driver = {
        .name = "Marvell 88E1518",
        .uid = 0x1410dd1,
-       .mask = 0xfffffff,
+       .mask = 0xffffffb,
        .features = PHY_GBIT_FEATURES,
        .config = &m88e1518_config,
        .startup = &m88e1011s_startup,


Reviewed-by: Stefan Roese <s...@denx.de>

Thanks,
Stefan
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to