On Wed, Dec 14, 2016 at 09:37:58AM +0100, Hans de Goede wrote: > Hi, > > On 13-12-16 21:28, Simon Glass wrote: > > Hi, > > > > On 12 December 2016 at 19:36, Jernej Skrabec <jernej.skra...@siol.net> > > wrote: > > > This patch series add support for HDMI output. Support for other, > > > newer, SoCs, which also uses DE2 and same or similar HDMI controller > > > and PHY can be easily added later (A83T/A64/H5/R40). Current driver > > > can also be easily extended with TV out support, just like video > > > driver for older Allwinner SoCs. > > > > > > While driver works, I would like to get few opinions first. > > > - From what I understand, drivers which supports DT are preferred. > > > Would it be better to rewrite this driver to support device tree? > > > > Yes I think so, and in fact it should use driver model also. > > > > The rockchip driver provides a reasonable example of how to split the > > driver up as you suggest below. The VIDEO driver provides the > > top-level video interface, DISPLAY drivers provide display output for > > the video, and you have PANEL as well for receiving the display > > output. VIDCONSOLE works automatically to display text. > > > > I actually took a bit of a look at this a few weeks ago so am happy to > > help with review or discussions. > > I'm all in favor of moving to the driver-model, but I believe that > we first need proper support for the DE2 and new HMDI encoder in > the kernel, so that the dt bindings are clear.
I agree, and I would even say that we shouldn't wait for that to happen either. I don't have any objection merging it without the driver model given how much time it took last time to have a driver merged in the kernel for that block (with its bindings), and then convert to the device model / DT once and when we have that. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
