On Mon, Dec 19, 2016 at 07:31:02PM +0900, Masahiro Yamada wrote: > Commit be72591bcd64 ("Kconfig: Move USE_ARCH_MEMCPY/MEMSET to > Kconfig") is misconversion. > > The original logic in include/configs/uniphier.h was as follows: > > #if !defined(CONFIG_SPL_BUILD) && !defined(CONFIG_ARM64) > #define CONFIG_USE_ARCH_MEMSET > #define CONFIG_USE_ARCH_MEMCPY > #endif > > This means those configs were enabled when building U-Boot proper, > but disabled when building SPL. Likewise for Tegra. > > Now "depends on !SPL" prevents any boards with SPL support > from reaching these options. This changed the behavior for > UniPhier and Tegra SoC family. > > Please notice these two options only control the U-Boot proper > build. As you see arch/arm/Makefile, ARM-specific memset/memcpy > are never compiled for SPL. So, __HAVE_ARCH_MEMCPY/MEMSET should > not set for SPL. > > Fixes: be72591bcd64 ("Kconfig: Move USE_ARCH_MEMCPY/MEMSET to Kconfig") > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
Ah, oops, thanks for spotting that one. > --- > > I am restoring the original behavior for now. > But, I have been wondering if we could remove these options entirely. We cannot. That was my first attempt and we have a handful of active (I checked) boards with tiny enough SPL constraints that switching to the optimized memcpy/memset push them over size limit and they do not have a "something" to disable to gain the space back. So I went with asking for asking for a conversion to enable by default these options as widely as possible as it's a good thing by and (no pun intended) large. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot