Hi Tom, On Mon, 23 Jan 2017 09:51:59 -0500 Tom Rini <tr...@konsulko.com> wrote:
> On Sat, Jan 21, 2017 at 09:22:47PM -0700, Warner Losh wrote: > > On Fri, Jan 20, 2017 at 8:51 PM, Simon Glass <s...@chromium.org> wrote: > > > Hi, > > > > > > On 17 January 2017 at 08:50, Emmanuel Vadot <m...@bidouilliste.com> wrote: > > >> Add kconfig file to enable API support > > >> > > >> Signed-off-by: Emmanuel Vadot <m...@bidouilliste.com> > > >> --- > > >> Kconfig | 2 ++ > > >> api/Kconfig | 9 +++++++++ > > >> 2 files changed, 11 insertions(+) > > >> create mode 100644 api/Kconfig > > >> > > >> diff --git a/Kconfig b/Kconfig > > >> index 39a4d938d8..6a93d8820f 100644 > > >> --- a/Kconfig > > >> +++ b/Kconfig > > >> @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY > > >> > > >> endmenu # Boot images > > >> > > >> +source "api/Kconfig" > > >> + > > >> source "common/Kconfig" > > >> > > >> source "cmd/Kconfig" > > >> diff --git a/api/Kconfig b/api/Kconfig > > >> new file mode 100644 > > >> index 0000000000..88b4f6c4e5 > > >> --- /dev/null > > >> +++ b/api/Kconfig > > >> @@ -0,0 +1,9 @@ > > >> +menu "API" > > >> + > > >> +config API > > >> + bool "Enable U-Boot API" > > >> + default n > > >> + help > > >> + This option enable the U-Boot API. > > > > > > Can you add a little detail about what the API is and what it is for? > > > > You can find complete documentation in the api directory. In brief, it > > allows the loaded binary to call back into the loader to do generic > > things like send network packets or read blocks from mass storage. > > Right. Can you re-word the "In brief.." slightly so it reads well under > the 'help' section and point to api/README for more details please? All right, I'll do that for v3. > > > Also, are you going to migrate all boards to use Kconfig for this > > > option and drop it from the whitelist? > > > > I'll leave that to Emmanuel. > > There's two boards that enable API today but tools/moveconfig.py may be > more overhead than just editing configs/PMC440_defconfig and > configs/lsxhl_defconfig (and the respective include/configs/ files). > > -- > Tom Ah, I've missed those. Would it make more sense to submit a patch that handle adding CONFIG_API into Kconfig (and changing configs for those two board and remove from the whitelist) separate from the FreeBSD config sets of patches ? Thanks, -- Emmanuel Vadot <m...@bidouilliste.com> <m...@freebsd.org> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
