On 03/10/2017 05:31 PM, Nicolas le bayon wrote: > From: Nicolas Le Bayon <nleba...@gmail.com> > > use dynamic allocation to consider all variable lengths
Of what ? Where ? Why ? > Signed-off-by: Nicolas Le Bayon <nleba...@gmail.com> > --- > drivers/usb/gadget/f_fastboot.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/f_fastboot.c > b/drivers/usb/gadget/f_fastboot.c > index 2160b1c..9bb3a95 100644 > --- a/drivers/usb/gadget/f_fastboot.c > +++ b/drivers/usb/gadget/f_fastboot.c > @@ -432,9 +432,19 @@ static void cb_getvar(struct usb_ep *ep, struct > usb_request *req) > else > strcpy(response, "FAILValue not set"); > } else { > - char envstr[32]; > + char *envstr = NULL; This var is inited by malloc() below, drop the = NULL . > + unsigned int len; > > - snprintf(envstr, sizeof(envstr) - 1, "fastboot.%s", cmd); > + len = strlen("fastboot.") + strlen(cmd) + 1; > + > + envstr = malloc(len); The len is only used here, just do malloc(strlen ..... )); > + if (!envstr) { > + error("variable malloc error"); This error message makes no sense ... > + fastboot_tx_write_str("FAILvar malloc error"); The indent of this whole block is wrong ... > + return; > + } > + > + sprintf(envstr, "fastboot.%s", cmd); > s = getenv(envstr); > if (s) { > strncat(response, s, chars_left); > @@ -442,6 +452,8 @@ static void cb_getvar(struct usb_ep *ep, struct > usb_request *req) > printf("WARNING: unknown variable: %s\n", cmd); > strcpy(response, "FAILVariable not implemented"); > } > + > + free(envstr); > } > fastboot_tx_write_str(response); > } > -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot